Re: [PATCH v2] can: dev: add struct data_bittiming_params to group FD parameters

[Marc Kleine-Budde]

On 02.05.2025 02:12:10, Vincent Mailhol wrote:
> This is a preparation patch for the introduction of CAN XL.
> 
> CAN FD and CAN XL uses similar bittiming parameters. Add one level of
> nesting for all the CAN FD parameters. Typically:
> 
>   priv->can.data_bittiming;
> 
> becomes:
> 
>   priv->can.fd.data_bittiming;
> 
> This way, the CAN XL equivalent (to be introduced later) would be:
> 
>   priv->can.xl.data_bittiming;
> 
> Add the new struct data_bittiming_params which contains all the data
> bittiming parameters, including the TDC and the callback functions.
> 
> This done, update all the CAN FD drivers to make use of the new
> layout.

Thanks for the series!

> Acked-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
> ---
> The CAN XL series is still blocked because of lack of information on
> the PWMS and PWML calculations, c.f.:
> 
>   https://lore.kernel.org/linux-can/68e8c449-a6ab-4958-af3c-852ece2694c2@xxxxxxxxxx/
> 
> Regardless, the above patch will be needed at some time. And instead
> of constantly rebasing it, I would rather have it merged early.
> 
> The other CAN XL preparation patches target a smaller subset of the
> tree and rebasing those is not an issue.
> 
> ** Changelog **
> 
> v1 -> v2:
> 
>   - add Oliver's Acked-by tag
>   - rebase on top of:
> 
>       [PATCH v5] can: mcp251xfd: fix TDC setting for low data bit rates
>       Link: https://lore.kernel.org/linux-can/20250430161501.79370-1-kelsey@xxxxxxxxxxxxx/T/#u
> 
>   Link: https://lore.kernel.org/linux-can/20250320144154.56611-2-mailhol.vincent@xxxxxxxxxx/

As "mcp251xfd: fix TDC setting for low data bit rates" will go through
the "can" and "net" tree, we have to wait until "net" is merged back to
"net-next".

Regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature