Re: [PATCH v7 08/11] gpio: max7360: Add MAX7360 gpio support
From: Andy Shevchenko
Date: Fri May 02 2025 - 09:04:13 EST
On Fri, May 02, 2025 at 02:31:13PM +0200, Mathieu Dubois-Briand wrote:
> On Fri May 2, 2025 at 12:39 PM CEST, Andy Shevchenko wrote:
> > On Mon, Apr 28, 2025 at 01:57:26PM +0200, Mathieu Dubois-Briand wrote:
...
> >> + irq_chip = devm_kzalloc(dev, sizeof(*irq_chip), GFP_KERNEL);
> >
> > Can this be made static const instead?
>
> Sorry, I don't think we can. We do have a few data that will vary:
> ->name, but above all ->irq_drv_data, as it will point on the regmap of
> the specific device.
I see, perhaps a (oneline) comment?
--
With Best Regards,
Andy Shevchenko