Re: [PATCH v3 06/23] media: iris: Remove deprecated property setting to firmware

[Dikshita Agarwal]

On 5/2/2025 5:57 PM, Bryan O'Donoghue wrote:
> On 01/05/2025 20:13, Dikshita Agarwal wrote:
>> HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER is deprecated and no longer
>> supported on current firmware, remove setting the same to firmware.
> 
> What about older firmware - what's the effect there ?
if you are referring to firmware being used in venus, its the same.
This property was never supported on SM8250 firmware.
> 
>> At the same time, remove the check for non-zero number of v4l2 controls
>> as some SOC might not expose any capability which requires v4l2 control.
> 
> Please break up patches like this one patch removing your legacy
> functionality - assuming that makes sense another patch amending your
> non-zero number of v4l2 controls.
> 
Ok, will split.

Thanks,
Dikshita
> Generally any commit log or patch title that requires "do this and do that"
> should be broken up @ the and.
> 
> ---
> bod