Re: [PATCH 7/7] selftests: vDSO: vdso_config: Avoid -Wunused-variables

[Muhammad Usama Anjum]

On 5/2/25 5:40 PM, Thomas Weißschuh wrote:
> Not all users of this header make use of all its variables.
> For example vdso_test_correctness.c does not use "versions":
> 
> In file included from vdso_test_correctness.c:22:
> vdso_config.h:61:20: warning: ‘versions’ defined but not used [-Wunused-variable]
>    61 | static const char *versions[7] = {
>       |                    ^~~~~~~~
> 
> Avoid those warnings through attribute((unused)).
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

> ---
>  tools/testing/selftests/vDSO/vdso_config.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_config.h b/tools/testing/selftests/vDSO/vdso_config.h
> index 722260f9756198956f0dfccced907284b6851e76..5fdd0f36233742bc47ae79f23d2cfae5a0f56dee 100644
> --- a/tools/testing/selftests/vDSO/vdso_config.h
> +++ b/tools/testing/selftests/vDSO/vdso_config.h
> @@ -58,6 +58,7 @@
>  #define VDSO_NAMES		1
>  #endif
>  
> +__attribute__((unused))
>  static const char *versions[7] = {
>  	"LINUX_2.6",
>  	"LINUX_2.6.15",
> @@ -68,6 +69,7 @@ static const char *versions[7] = {
>  	"LINUX_5.10"
>  };
>  
> +__attribute__((unused))
>  static const char *names[2][7] = {
>  	{
>  		"__kernel_gettimeofday",
> 


-- 
Regards,
Usama