Re: [PATCH v2 1/1] x86/reboot: KVM: Guard nmi_shootdown_cpus_on_restart() with ifdeffery

[Andy Shevchenko]

On Tue, Apr 08, 2025 at 07:56:58AM -0700, Dave Hansen wrote:
> On 4/8/25 07:36, Andy Shevchenko wrote:
> > On Tue, Apr 08, 2025 at 07:17:51AM -0700, Dave Hansen wrote:
> >> On 4/8/25 05:19, Andy Shevchenko wrote:
> >>> Any news here? Build error is still reproducible.
> >> In the end, adding the #ifdefs leads to worse code, less maintainable
> >> code. I'll take the occasional actual unused static inline in a .c file
> >> over a mess of #ifdefs to make the compiler happy.
> >>
> >> I really think that warning needs to go away in some way, shape or form.
> >> Either get rid of it entirely, or kick it out of -Wall somehow. It's a
> >> super pedantic warning that leads to worse code most of the time.
> > Does it mean you can take Sean's approach?
> 
> It looks fine at first glance.

Can it be applied, please? The problem still persists as of today (v6.15-rc4).

-- 
With Best Regards,
Andy Shevchenko