Re: [PATCH] perf hist: Remove output field from sort-list properly

From: Arnaldo Carvalho de Melo
Date: Fri May 02 2025 - 11:54:43 EST


On Wed, Apr 30, 2025 at 11:03:21AM -0700, Namhyung Kim wrote:
> When it removes an output format for cancelled children or latency, it
> should delete itself from the sort list as well. Otherwise assertion
> in fmt_free() will fire.
>
> $ perf report -H --stdio
> perf: ui/hist.c:603: fmt_free: Assertion `!(!list_empty(&fmt->sort_list))' failed.
> Aborted (core dumped)
>
> Also convert to perf_hpp__column_unregister() for the same open codes.
>
> Fixes: dbd11b6bdab12f60 ("perf hist: Remove formats in hierarchy when cancel children")
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Tested and added the following patch just before this one.

Please check.

Thanks, applied to perf-tools-next.

- Arnaldo