Re: [PATCH 0/3] Standardize link status check to return bool

[Hans Zhang]

On 2025/5/2 23:36, Manivannan Sadhasivam wrote:
> On Tue, Apr 29, 2025 at 01:10:24AM +0800, Hans Zhang wrote:
> > 1. PCI: dwc: Standardize link status check to return bool.
> > 2. PCI: mobiveil: Refactor link status check.
> > 3. PCI: cadence: Simplify j721e link status check.
>
> Thanks for the cleanup. Looks good to me except the redundancy conversion that
> Niklas noted. So with that change,
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Dear Mani,

Thank you very much for your reply. I have sent version v2 to resolve 
Niklas' review opinions.

Best regards,
Hans

> - Mani
>
> > Hans Zhang (3):
> >    PCI: dwc: Standardize link status check to return bool.
> >    PCI: mobiveil: Refactor link status check.
> >    PCI: cadence: Simplify j721e link status check.
> >
> >   drivers/pci/controller/cadence/pci-j721e.c             | 6 +-----
> >   drivers/pci/controller/dwc/pci-dra7xx.c                | 2 +-
> >   drivers/pci/controller/dwc/pci-exynos.c                | 4 ++--
> >   drivers/pci/controller/dwc/pci-keystone.c              | 5 ++---
> >   drivers/pci/controller/dwc/pci-meson.c                 | 6 +++---
> >   drivers/pci/controller/dwc/pcie-armada8k.c             | 6 +++---
> >   drivers/pci/controller/dwc/pcie-designware.c           | 2 +-
> >   drivers/pci/controller/dwc/pcie-designware.h           | 4 ++--
> >   drivers/pci/controller/dwc/pcie-dw-rockchip.c          | 2 +-
> >   drivers/pci/controller/dwc/pcie-histb.c                | 9 +++------
> >   drivers/pci/controller/dwc/pcie-keembay.c              | 2 +-
> >   drivers/pci/controller/dwc/pcie-kirin.c                | 7 ++-----
> >   drivers/pci/controller/dwc/pcie-qcom-ep.c              | 4 ++--
> >   drivers/pci/controller/dwc/pcie-qcom.c                 | 2 +-
> >   drivers/pci/controller/dwc/pcie-rcar-gen4.c            | 2 +-
> >   drivers/pci/controller/dwc/pcie-spear13xx.c            | 7 ++-----
> >   drivers/pci/controller/dwc/pcie-tegra194.c             | 2 +-
> >   drivers/pci/controller/dwc/pcie-uniphier.c             | 2 +-
> >   drivers/pci/controller/dwc/pcie-visconti.c             | 2 +-
> >   drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c | 9 ++-------
> >   drivers/pci/controller/mobiveil/pcie-mobiveil.h        | 2 +-
> >   21 files changed, 34 insertions(+), 53 deletions(-)
> >
> >
> > base-commit: 286ed198b899739862456f451eda884558526a9d
> > --
> > 2.25.1