Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937

[barnabas . czeman]

On 2025-04-25 23:02, Konrad Dybcio wrote:
> On 4/25/25 10:22 PM, barnabas.czeman@xxxxxxxxxxxxxx wrote:
> > On 2025-04-25 21:26, Konrad Dybcio wrote:
> > > On 4/25/25 5:13 PM, barnabas.czeman@xxxxxxxxxxxxxx wrote:
> > > > On 2025-04-25 11:57, Konrad Dybcio wrote:
> > > > > On 4/23/25 4:46 PM, barnabas.czeman@xxxxxxxxxxxxxx wrote:
> > > > > > On 2025-04-23 16:03, Konrad Dybcio wrote:
> > > > > > > On 4/21/25 10:18 PM, Barnabás Czémán wrote:
> > > > > > > > From: Dang Huynh <danct12@xxxxxxxxxx>
> > > > > > > >
> > > > > > > > Add initial support for MSM8937 SoC.
> > > > > > > >
> > > > > > > > Signed-off-by: Dang Huynh <danct12@xxxxxxxxxx>
> > > > > > > > Co-developed-by: Barnabás Czémán 
> > > > > > > > <barnabas.czeman@xxxxxxxxxxxxxx>
> > > > > > > > Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
> > > > > > > > ---
> > > > >
> > > > > [...]
> > > > >
> > > > > > > > +            gpu_opp_table: opp-table {
> > > > > > > > +                compatible = "operating-points-v2";
> > > > > > > > +
> > > > > > > > +                opp-19200000 {
> > > > > > > > +                    opp-hz = /bits/ 64 <19200000>;
> > > > > > > > +                    opp-supported-hw = <0xff>;
> > > > > > >
> > > > > > > The comment from the previous revision still stands
> > > > > > If i remove opp-supported-hw i will got -22 EINVAL messages and 
> > > > > > the opp will be not fine.
> > > > >
> > > > > Right, I have a series pending to improve this situation a bit..
> > > > >
> > > > > In the meantime, you should be able to define the nvmem cell and
> > > > > fill in meaningful values for this platform
> > > > As I wrote in the previous revision there is no nvmem for GPU on 
> > > > msm8937 only on msm8940.
> > >
> > > This seems not to be the case
> > >
> > > https://github.com/penglezos/android_kernel_xiaomi_msm8953/blob/pie/arch/arm/boot/dts/qcom/msm8937.dtsi#L2046-L2191
> > These are on msm-4.9 was moved to msm8940.dtsi
> > https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8937-gpu.dtsi#L162
> > https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.10.6.2.c26-01500-89xx.0/arch/arm64/boot/dts/qcom/msm8940.dtsi#L600
> > 475 MHz and 500 MHz is for msm8940 at least based on 4.9
>
> I'll try to get a more conclusive answer internally
Any information? I am thinking about define nvmem cells based on 3.18
> Konrad