Re: [PATCH v2 3/4] clk: qcom: camcc-sc8180x: Add SC8180X camera clock controller driver

From: Dmitry Baryshkov
Date: Fri May 02 2025 - 18:35:46 EST


On Wed, Apr 30, 2025 at 04:08:57PM +0530, Satya Priya Kakitapalli wrote:
> Add support for the camera clock controller for camera clients to
> be able to request for camcc clocks on SC8180X platform.
>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> ---

Would it make sense to merge this driver with the camcc-sm8150.c? It
seems that the blocks are pretty similar.

> drivers/clk/qcom/Kconfig | 10 +
> drivers/clk/qcom/Makefile | 1 +
> drivers/clk/qcom/camcc-sc8180x.c | 2897 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 2908 insertions(+)
>

--
With best wishes
Dmitry