Re: [PATCH v7 6/6] platform/x86: Add Lenovo Other Mode WMI Driver

[ALOK TIWARI]

Hi Derek,

Thanks for your patch.

On 03-05-2025 05:31, Derek J. Clark wrote:
> +	attribute_id =
> +		FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) |
> +		FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) |
> +		FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, LWMI_GZ_THERMAL_MODE_CUSTOM) |
> +		FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id);
> +
> +	//capdata = devm_kzalloc(&priv->wdev->dev, sizeof(*capdata), GFP_KERNEL);
> +	//if (!capdata)
> +	//	return -ENOMEM;

remove this dead code

> +
> +	ret = lwmi_cd01_get_data(priv->cd01_list, attribute_id, &capdata);
> +	if (ret)
> +		return ret;


Reviewed-by: Alok Tiwari <alok.a.tiwari@xxxxxxxxxx>

Thanks,
Alok