Re: [PATCH v2 2/3] randstruct: Force full rebuild when seed changes

[Kees Cook]

On Sat, May 03, 2025 at 03:13:06PM +0900, Masahiro Yamada wrote:
> On Sat, May 3, 2025 at 7:54 AM Kees Cook <kees@xxxxxxxxxx> wrote:
> > +$(obj)/randstruct_hash.h $(obj)/randstruct.seed: $(gen-randstruct-seed) FORCE
> >         $(call if_changed,create_randstruct_seed)
> [...]
> So, this rule is executed twice; for randstruct_hash.h and for randstruct.seed
> 
> randstruct_hash.h and randstruct.seed will contain different hash values.
> 
> I recommend keeping the current code.

Agreed -- getting stuff into generated is much preferred. Thank you!

-- 
Kees Cook