Re: [RFC PATCH v6 07/32] KVM: x86: apic_test_vector() to common code

[Neeraj Upadhyay]

On 5/24/2025 5:42 PM, Borislav Petkov wrote: 
> 
> The previous patch is moving those *_POS() macros to arch/x86/kvm/lapic.c, now
> this patch is doing rename-during-move to the new macros.
> 
> Why can't you simply do the purely mechanical moves first and then do the
> renames? Didn't I explain it the last time? Or is it still unclear?
> 

I thought it was clear to me when you explained last time. However, I did this
rename-during-move because of below reason. Please correct me if I am wrong here.

VEC_POS, REG_POS are kvm-internal wrappers for APIC_VECTOR_TO_BIT_NUMBER/
APIC_VECTOR_TO_REG_OFFSET macros which got defined in patch 01/32. Prior to patch
06/32, these macros were defined in kvm-internal header arch/x86/kvm/lapic.h. Using
VEC_POS, REG_POS kvm-internal macros in x86 common header file (arch/x86/include/asm/apic.h)
in this patch did not look correct to me and as APIC_VECTOR_TO_BIT_NUMBER/APIC_VECTOR_TO_REG_OFFSET
are already defined in arch/x86/include/asm/apic.h, I used them.

Is adding this information in commit log of this patch sufficient or do you have some
other suggestion for doing this?


- Neeraj