Re: [PATCH net v5] net/mlx5: Add error handling in mlx5_query_nic_vport_node_guid()

[Tariq Toukan]

On 24/05/2025 19:34, Wentao Liang wrote:
> The function mlx5_query_nic_vport_node_guid() calls the function
> mlx5_query_nic_vport_context() but does not check its return value.
> A proper implementation can be found in mlx5_nic_vport_query_local_lb().
>
> Add error handling for mlx5_query_nic_vport_context(). If it fails, free
> the out buffer via kvfree() and return error code.
>
> Fixes: 9efa75254593 ("net/mlx5_core: Introduce access functions to query vport RoCE fields")
> Cc: stable@xxxxxxxxxxxxxxx # v4.5
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> ---
> v5: Remove error tag.
> v4: Fix code error.
> v3: Explicitly mention target branch. Change improper code.
> v2: Remove redundant reassignment. Fix typo error.

Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>