Re: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller
From: Krzysztof Kozlowski
Date: Mon May 26 2025 - 08:58:34 EST
On 26/05/2025 09:07, Mahapatra, Amit Kumar wrote:
>>> - if:
>>> @@ -132,11 +139,11 @@ properties:
>>> maxItems: 1
>>>
>>> resets:
>>> - minItems: 2
>>> + minItems: 1
>>
>> I think you're still missing one of the things Krzysztof requested on v1, cos you
>> reduce minItems for all platforms without restricting it back to 2 for non-versal
>> platforms.
>
> I believe we can remove the "resets" and corresponding "reset-names"
> properties from here, as their default minItems/maxItems are already
> taken care of in the else block [1].
>
> [1] https://github.com/torvalds/linux/blob/0ff41df1cb268fc69e703a08a57ee14ae967d0ca/Documentation/devicetree/bindings/spi/cdns%2Cqspi-nor.yaml#L39
I don't see anything fixed there.
Best regards,
Krzysztof