Re: [PATCH net-next v2 2/3] dt-bindings: net: qcom,ipa: Add sram property for describing IMEM slice
From: Krzysztof Kozlowski
Date: Tue May 27 2025 - 07:38:30 EST
On 27/05/2025 13:26, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> The IPA driver currently grabs a slice of IMEM through hardcoded
> addresses. Not only is that ugly and against the principles of DT,
> but it also creates a situation where two distinct platforms
> implementing the same version of IPA would need to be hardcoded
> together and matched at runtime.
>
> Instead, do the sane thing and accept a handle to said region directly.
>
> Don't make it required on purpose, as a) it's not there on ancient
> implementations (currently unsupported) and we're not yet done with
> filling the data across al DTs.
>
> Reviewed-by: Alex Elder <elder@xxxxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof