Re: [PATCH net-next V10 1/6] devlink: Extend devlink rate API with traffic classes bandwidth management

[Jakub Kicinski]

On Sun, 25 May 2025 17:57:28 +0300 Carolina Jubran wrote:
> >> +      -
> >> +        name: rate-tc-bw
> >> +        type: u32
> >> +        doc: |
> >> +             Specifies the bandwidth allocation for the Traffic Class as a
> >> +             percentage.
> >> +        checks:
> >> +          min: 0
> >> +          max: 100  
> > 
> > Why in percentage? I don't think any existing param in devlink rate
> > or net shapers is in percentage right? Not according to what i can
> > grok about the uAPI.
> >   
> 
> I thought percentage might fit better here because it lets users clearly 
> set the bandwidth share for each traffic class. While this isn’t the 
> same as tx_weight in devlink-rate, the idea is related since both use 
> relative values. If there isn’t a strong reason against it, I’d like to 
> keep using percentages here.

The existing APIs use absolute values for b/w limits.
If you want to diverge please provide clear and realistic use cases.