Re: [PATCH net-next 2/4] net: spacemit: Add K1 Ethernet MAC

From: Vivian Wang
Date: Sun Jun 15 2025 - 23:04:22 EST


Hi Jakub,

Thanks for your review.

On 6/13/25 21:31, Jakub Kicinski wrote:
> On Fri, 13 Jun 2025 10:15:08 +0800 Vivian Wang wrote:
>> + rx_ring->desc_addr = dma_alloc_coherent(&pdev->dev, rx_ring->total_size,
>> + &rx_ring->desc_dma_addr,
>> + GFP_KERNEL);
>> + if (!rx_ring->desc_addr) {
>> + kfree(rx_ring->rx_desc_buf);
>> + return -ENOMEM;
>> + }
>> +
>> + memset(rx_ring->desc_addr, 0, rx_ring->total_size);
> dma_alloc_coherent() already clears memory.

Thanks, I will remove memset in next version.

Regards,
Vivian "dramforever" Wang