Re: [PATCH] wifi: carl9170: do not ping device which has failed to load firmware

[Christian Lamparter]

Hi,

On 6/16/25 12:01 PM, Dmitry Antipov wrote:
> On 6/15/25 10:54 PM, Fedor Pchelkin wrote:
>
> > So it looks like ar->registered being false here is a "correct" failure
> > condition, i.e. it can be expected when the certain phase of the driver
> > initialization fails and should be handled without any WARNs.
>
> Looking through Documentation/process/coding-style.rst, it may be
> better to use pr_warn_once() instead; anyway I would prefer leave
> the final decision to the maintainer.

Sure. I think you made a fine point. Grepping through drivers/net/wireless
in the (wireless-testing wt-2025-06-08-24) it seems that this could be the
first  pr_warn_once in there.

@Dmitry, would you please respin the patch? Thank you!

Regards,
Christian