Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths

[Thomas Zimmermann]

Hi

Am 20.06.25 um 14:07 schrieb Luca Weiss:
> On Fri Jun 20, 2025 at 1:28 PM CEST, Thomas Zimmermann wrote:
> > Hi
> >
> > Am 20.06.25 um 13:07 schrieb Luca Weiss:
> > > Hi Thomas,
> > >
> > > On Fri Jun 20, 2025 at 1:02 PM CEST, Thomas Zimmermann wrote:
> > > > Hi
> > > >
> > > > Am 20.06.25 um 12:31 schrieb Luca Weiss:
> > > > > Some devices might require keeping an interconnect path alive so that
> > > > > the framebuffer continues working. Add support for that by setting the
> > > > > bandwidth requirements appropriately for all provided interconnect
> > > > > paths.
> > > > >
> > > > > Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> > > > > ---
> > > > >     drivers/video/fbdev/simplefb.c | 83 ++++++++++++++++++++++++++++++++++++++++++
> > > > >     1 file changed, 83 insertions(+)
> > > > >
> > > > > diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> > > > > index be95fcddce4c8ca794826b805cd7dad2985bd637..ca73e079fd13550ddc779e84db80f7f9b743d074 100644
> > > > > --- a/drivers/video/fbdev/simplefb.c
> > > > > +++ b/drivers/video/fbdev/simplefb.c
> > > > > @@ -27,6 +27,7 @@
> > > > >     #include <linux/parser.h>
> > > > >     #include <linux/pm_domain.h>
> > > > >     #include <linux/regulator/consumer.h>
> > > > > +#include <linux/interconnect.h>
> > > > With alphabetical sorting:
> > > >
> > > > Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > > Thanks for the reviews!
> > >
> > > For both simpledrm.c and simplefb.c, the includes are not strictly
> > > alphabetically sorted (1 mis-sort in simpledrm, 3 in simplefb), shall I
> > > just try and slot it into the best fitting place, or make them sorted in
> > > my patch? Or I can add a separate commit for each driver before to sort
> > > them.
> > >
> > > Let me know!
> > Best is to try to fit it into the <linux/*> block. In simpledrm, it's
> > probably my mistake. Don't bother with sending an extra cleanup if you
> > don't want to.
> I was mostly asking whether this diff is okay as part of my patch (for
> just adding <linux/interconnect.h>)
>
> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
> index be95fcddce4c..f2efa4b51401 100644
> --- a/drivers/video/fbdev/simplefb.c
> +++ b/drivers/video/fbdev/simplefb.c
> @@ -13,18 +13,19 @@
>    */
>   
>   #include <linux/aperture.h>
> +#include <linux/clk.h>
>   #include <linux/errno.h>
>   #include <linux/fb.h>
> +#include <linux/interconnect.h>
>   #include <linux/io.h>
>   #include <linux/module.h>
> -#include <linux/platform_data/simplefb.h>
> -#include <linux/platform_device.h>
> -#include <linux/clk.h>
>   #include <linux/of.h>
>   #include <linux/of_address.h>
>   #include <linux/of_clk.h>
>   #include <linux/of_platform.h>
>   #include <linux/parser.h>
> +#include <linux/platform_data/simplefb.h>
> +#include <linux/platform_device.h>
>   #include <linux/pm_domain.h>
>   #include <linux/regulator/consumer.h>
>   
>
> Or if you want this churn to be a separate commit. Either way is fine
> with me, just trying to figure out the preferences of this subsystem :)

If you want to resort the entries, please do so in a separate patch.

Best regards
Thomas

> Regards
> Luca

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)