Re: [PATCH 1/5] serial: 8250: extract serial8250_init_mctrl()

[Jiri Slaby]

On 23. 06. 25, 20:11, Andy Shevchenko wrote:
> Mon, Jun 23, 2025 at 09:46:02AM +0200, Jiri Slaby (SUSE) kirjoitti:
> > After commit 795158691cc0 ("serial: 8250: extract
> > serial8250_initialize()"), split serial8250_initialize() even more --
> > the mctrl part of this code can be separated into
> > serial8250_init_mctrl() -- done now.
>
> ...
>
> > +static void serial8250_init_mctrl(struct uart_port *port)
> > +{
> > +	struct uart_8250_port *up = up_to_u8250p(port);
> > +
> > +	if (up->port.flags & UPF_FOURPORT) {
> > +		if (!up->port.irq)
> > +			up->port.mctrl |= TIOCM_OUT1;
>
> I am not sure I understand why it was changed from using port directly to
> up->port.

Ugh, that's a mistake. During rebase likely. Thanks for catching.


--
js
suse labs