Re: 回覆: [PATCH 0/7] Add ASPEED PCIe Root Complex support

[Neil Armstrong]

On 20/06/2025 10:20, Jacky Chou wrote:
> > > This series has been tested on AST2600/AST2700 platforms and enables
> > > PCIe device enumeration and operation.
> > >
> > > Feedback and review are welcome.
> >
> > So it seems all PCIe RC code is bundled in a single driver and there's no PCIe
> > PHY driver code, is there a reason for that ? If yes I think it should be described
> > in the cover letter.
>
> Yes, because our design includes the PCIe RC and the PCIe EPs.
> The two functions use the same PCIe PHY and are mutually exclusive.
> And there are different configurations on RC and EP.
> Therefore, we do not use a phy driver to configure our PCIe but use
> the phandle of phy syscon to set the RC and EP drivers separately.

I don't get why a PHY drive could not exist, it could be used by either
the RC or EP PCIe driver in an exclusive way.

Neil

> I will add more description in next version.
>
> Thanks,
> Jacky