RE: [PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time on shutdown

From: Usyskin, Alexander
Date: Wed Jun 25 2025 - 04:00:14 EST


> Subject: [PATCH 03/10] mei: vsc: Don't call vsc_tp_reset() a second time on
> shutdown
>
> Now that mei_vsc_hw_reset() no longer re-inits the VSC when called from
> mei_stop(), vsc_tp_shutdown() unregistering the platform-device, which
> runs mei_stop() is sufficient to put the VSC in a clean state.
>

Reviewed-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>

> Signed-off-by: Hans de Goede <hansg@xxxxxxxxxx>
> ---
> drivers/misc/mei/vsc-tp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c
> index 99a55451e1fc..4a262e2117e4 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -547,8 +547,6 @@ static void vsc_tp_shutdown(struct spi_device *spi)
>
> mutex_destroy(&tp->mutex);
>
> - vsc_tp_reset(tp);
> -
> free_irq(spi->irq, tp);
> }
>
> --
> 2.49.0