Re: [PATCH 2/7] kcov: factor out struct kcov_state

From: Alexander Potapenko
Date: Wed Jun 25 2025 - 12:38:47 EST


> > if (data->saved_kcov) {
> > - kcov_start(t, data->saved_kcov, data->saved_size,
> > - data->saved_area, data->saved_mode,
> > - data->saved_sequence);
> > - data->saved_mode = 0;
> > - data->saved_size = 0;
> > - data->saved_area = NULL;
> > - data->saved_sequence = 0;
> > + kcov_start(t, data->saved_kcov, &data->saved_state);
> > + data->saved_state = (struct kcov_state){ 0 };
>
> Unsure how the compiler optimizes this (does it create a temporary and
> then assigns it?). Maybe just memset is clearer.

Missed this one - I am not convinced a memset is clearer, but recent
patches mention that '{ }' is preferred over '{ 0 }'.