Re: [PATCH v3 1/6] x86/sme: Use percpu boolean to control wbinvd during kexec

From: Edgecombe, Rick P
Date: Thu Jun 26 2025 - 20:40:48 EST


On Fri, 2025-06-27 at 00:37 +0000, Huang, Kai wrote:
> > Arguably the supported/enabled part could be moved to a separate earlier
> > patch.
> > The code change would just get immediately replaced, but the benefit would
> > be
> > that a bisect would show which part of the change was responsible.
>
> I am not a fan of splitting the new variable and the user into different
> patches, as long as the patch isn't too big to review.  You need to review
> them together anyway I think, so arguably putting them together is easier to
> review.

How about if Tom thinks there is any risk, we can split them for bisectability
help. Otherwise reduce the churn.