Re: [PATCH v3 1/3] dt-bindings: display: samsung,exynos7-decon: add properties for iommus and ports

[Kaustabh Chakraborty]

On 2025-06-27 07:50, Krzysztof Kozlowski wrote:
> On Fri, Jun 27, 2025 at 12:50:28AM +0530, Kaustabh Chakraborty wrote:
> > Similar to FIMD and Exynos5433's DECON, the Exynos7 DECON hardware:
> > - May optionally require an IOMMU to initialize a display region.
> > - May require a port connection to another block, say an MIC or a DSI
> >   master.
> >
> > Document these bindings in the devicetree schema.
> >
> > Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> > ---
> >  .../bindings/display/samsung/samsung,exynos7-decon.yaml           | 8 
> > ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml 
> > b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
> > index 
> > 53916e4c95d8c0369138941a556c23f5d42fbd39..1e9500c86590d555cfa6f04790e2b64da291b78b 
> > 100644
> > --- 
> > a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
> > +++ 
> > b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml
> > @@ -80,6 +80,14 @@ properties:
> >        - const: vsync
> >        - const: lcd_sys
> >
> > +  iommus:
> > +    maxItems: 1
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +    description:
> > +      Contains a port which is connected to mic or dsim node.
>
> You need to list and describe the ports.

-    description:
-      Contains a port which is connected to mic or dsim node.
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/properties/port
+        description:
+          Input port which is connected to either a Mobile Image
+          Compressor (MIC) or a DSI Master device.

I assume you want something like this?
Is the formatting correct? Should there be a space between
ports:$ref and ports:properties?

> Best regards,
> Krzysztof