Re: [PATCH v10 4/7] iio: accel: adxl345: add inactivity feature

From: Jonathan Cameron
Date: Sat Jun 28 2025 - 12:08:58 EST



> ...
>
> > + case ADXL345_INACTIVITY:
> > + axis_ctrl = ADXL345_INACT_X_EN | ADXL345_INACT_Y_EN |
> > + ADXL345_INACT_Z_EN;
>
> Consider
> axis_ctrl =
> ADXL345_INACT_X_EN | ADXL345_INACT_Y_EN | ADXL345_INACT_Z_EN;
>
> (yes, I see that it's longer than 80, but it might worth doing it for the sake of
> consistency with the previous suggestion).
Hmm. I'd go longer rather than do that just because it looks really ugly.

axis_ctrl = ADXL345_INACT_X_EN | ADXL345_INACT_Y_EN | ADXL345_INACT_Z_EN;

I don't care that much as long as long lines are justified by readability. Here
I think either Andy's suggestion or the all on one line are justified.

Tomorrow I may have a different view :(