RE: [PATCH v3 1/1] spi: spi-cadence-quadspi: Fix pm runtime unbalance

[Romli, Khairul Anuar]

> To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: Romli, Khairul Anuar <khairul.anuar.romli@xxxxxxxxxx>; open list:SPI
> SUBSYSTEM <linux-spi@xxxxxxxxxxxxxxx>; open list <linux-
> kernel@xxxxxxxxxxxxxxx>; Gerlach, Matthew <matthew.gerlach@xxxxxxxxxx>;
> Romli, Khairul Anuar <khairul.anuar.romli@xxxxxxxxxx>
> Subject: Re: [PATCH v3 1/1] spi: spi-cadence-quadspi: Fix pm runtime
> unbalance
> 
> On Fri, Jun 27, 2025 at 07:39:24AM +0300, Dan Carpenter wrote:
> > On Thu, Jun 26, 2025 at 11:37:53PM -0500, Dan Carpenter wrote:
> 
> > > In other words, if we failed there was some slightly complicated
> > > cleanup to do.  But now it will do the cleanup and free things on
> > > the success path if we're in cqspi->use_direct_mode.
> 
> > I suck at email.  What I meant was delete the if block:
> 
> > -	if (cqspi->rx_chan) {
> > -		dma_release_channel(cqspi->rx_chan);
> > -		goto probe_setup_failed;
> > -	}
> > -
> 
> Can you submit a fix for this please?  The patch is already applied and in Linus'
> tree.

I'll submit the fix for this.