Re: [PATCH net-next] gve: make IRQ handlers and page allocation NUMA aware

[Jakub Kicinski]

On Fri, 27 Jun 2025 18:31:41 +0000 Harshitha Ramamurthy wrote:
> -	rx->qpl_copy_pool = kvcalloc(rx->qpl_copy_pool_mask + 1,
> -				     sizeof(rx->qpl_copy_pool[0]),
> -				     GFP_KERNEL);
> +	rx->qpl_copy_pool =
> +		kvzalloc_node(array_size(rx->qpl_copy_pool_mask + 1,
> +					 sizeof(rx->qpl_copy_pool[0])),
> +			      GFP_KERNEL, priv->numa_node);
>  
>  	if (!rx->qpl_copy_pool) {

kvcalloc_node() exists for more than a year now.

nit: when you respin could you shift the allocation so that the empty
line appears before the kvcalloc_node() call rather than between it
and the error check?
-- 
pw-bot: cr