Re: [PATCH v2 2/2] NTB: epf: Add Renesas rcar support

[Jerome Brunet]

On Tue 24 Jun 2025 at 16:02, Frank Li <Frank.li@xxxxxxx> wrote:

> On Tue, Jun 24, 2025 at 06:06:17PM +0200, Jerome Brunet wrote:
>> Add virtual non-transparent bridge support for Renesas rcar platform
>>
>> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>> ---
>>  drivers/ntb/hw/epf/ntb_hw_epf.c | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c
>> index e8eb3adc6cecd2d52235a3f0b6b5a59ec58f1d73..97c9ed7e4dc27dabd21d3f083cc70d55bb280df8 100644
>> --- a/drivers/ntb/hw/epf/ntb_hw_epf.c
>> +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c
>> @@ -747,6 +747,16 @@ static const enum pci_barno mx8_map[NTB_BAR_NUM] = {
>>  	[BAR_MW4]	= NO_BAR
>>  };
>>
>> +static const enum pci_barno rcar_barno[NTB_BAR_NUM] = {
>
> Nit: suppose neend't NTB_BAR_NUM.

Not strictly no, but it does not hurt.
It's an obvious reminder that of that table is fixed.

I'll keep it that way if you don't mind.

>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>
>> +	[BAR_CONFIG]	= BAR_0,
>> +	[BAR_PEER_SPAD]	= BAR_0,
>> +	[BAR_DB]	= BAR_4,
>> +	[BAR_MW1]	= BAR_2,
>> +	[BAR_MW2]	= NO_BAR,
>> +	[BAR_MW3]	= NO_BAR,
>> +	[BAR_MW4]	= NO_BAR,
>> +};
>> +
>>  static const struct pci_device_id ntb_epf_pci_tbl[] = {
>>  	{
>>  		PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_J721E),
>> @@ -758,6 +768,11 @@ static const struct pci_device_id ntb_epf_pci_tbl[] = {
>>  		.class = PCI_CLASS_MEMORY_RAM << 8, .class_mask = 0xffff00,
>>  		.driver_data = (kernel_ulong_t)mx8_map,
>>  	},
>> +	{
>> +		PCI_DEVICE(PCI_VENDOR_ID_RENESAS, 0x0030),
>> +		.class = PCI_CLASS_MEMORY_RAM << 8, .class_mask = 0xffff00,
>> +		.driver_data = (kernel_ulong_t)rcar_barno,
>> +	},
>>  	{ },
>>  };
>>
>>
>> --
>> 2.47.2
>>

-- 
Jerome