Re: [PATCH v3 1/2] dt-bindings: ethernet: eswin: Document for EIC7700 SoC

From: Andrew Lunn
Date: Thu Jul 03 2025 - 12:07:02 EST


> + ethernet@50400000 {
> + compatible = "eswin,eic7700-qos-eth", "snps,dwmac-5.20";
> + reg = <0x50400000 0x10000>;
> + interrupt-parent = <&plic>;
> + interrupt-names = "macirq";
> + interrupts = <61>;
> + phy-mode = "rgmii";

Please don't user 'rgmii' in examples. It is normally wrong, and we
don't want DT developers copying it into real DT binding, just for me
to tell them it is wrong.

Andrew