Re: [PATCH 23/23] binfmt_elf: Warn on missing or suspicious regset note names

From: Kees Cook
Date: Sat Jul 05 2025 - 11:15:46 EST




On July 1, 2025 6:56:16 AM PDT, Dave Martin <Dave.Martin@xxxxxxx> wrote:
>Un-migrated arches will trigger WARNs with this patch applied, and
>arches that don't specify codedump note names will always get
>"LINUX" -- since the whole point is to stop guessing the note name in
>the core code.
>
>On _unpatched_ arches (only) this is a potential ABI break for the
>NT_PRFPREG note (which, for historical reasons, is a "CORE" note even
>though it is OS-specific on most or all arches).

After all your arch patches, aren't all the archs using the correct values? Is the WARN for new or out-of-tree archs?

-Kees

--
Kees Cook