Re: [PATCH] rust: miscdevice: remove unnecessary import

From: Greg Kroah-Hartman
Date: Sat Jul 05 2025 - 12:06:09 EST


On Sat, Jul 05, 2025 at 11:56:19AM -0400, Tamir Duberstein wrote:
> On Fri, Jul 4, 2025 at 3:50 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > `kernel::str::CStr` is included in the prelude.
> >
> > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
> > ---
> > rust/kernel/miscdevice.rs | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
> > index 288f40e79906..8309d656088a 100644
> > --- a/rust/kernel/miscdevice.rs
> > +++ b/rust/kernel/miscdevice.rs
> > @@ -17,7 +17,6 @@
> > mm::virt::VmaNew,
> > prelude::*,
> > seq_file::SeqFile,
> > - str::CStr,
> > types::{ForeignOwnable, Opaque},
> > };
> > use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin};
> >
> > ---
> > base-commit: 769e324b66b0d92d04f315d0c45a0f72737c7494
> > change-id: 20250704-cstr-include-miscdevice-4c5cb26a0ece
> >
> > Best regards,
> > --
> > Tamir Duberstein <tamird@xxxxxxxxx>
> >
>
> Oops, should have sent this to Greg. Sent
> https://lore.kernel.org/all/20250705-miscdevice-maintainers-v1-1-9a6b67f7602f@xxxxxxxxx/
> to make this easier in the future.

Thanks, I just noticed this as well. I'll queue up this, and the
MAINTAINERS update when I get a chance tomorrow or so.

greg k-h