Re: [PATCH v10 08/11] gpio: max7360: Add MAX7360 gpio support

[Mathieu Dubois-Briand]

On Fri May 30, 2025 at 8:03 PM CEST, Andy Shevchenko wrote:
> On Fri, May 30, 2025 at 12:00:16PM +0200, Mathieu Dubois-Briand wrote:
>> Add driver for Maxim Integrated MAX7360 GPIO/GPO controller.
>> 
>> Two sets of GPIOs are provided by the device:
>> - Up to 8 GPIOs, shared with the PWM and rotary encoder functionalities.
>>   These GPIOs also provide interrupts on input changes.
>> - Up to 6 GPOs, on unused keypad columns pins.
>
> LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks!

>
> ...
>
>> +#include <linux/gpio/driver.h>
>
> Do we still need this header? I mean do we have anything used from it here?
>

Yes, I believe we do, as we access gpio_chip members in
max7360_gpo_init_valid_mask().


-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com