Re: [PATCH] driver core: auxiliary bus: fix OF node leak

[Jerome Brunet]

On Tue 08 Jul 2025 at 12:04, Johan Hovold <johan@xxxxxxxxxx> wrote:

> On Tue, Jul 08, 2025 at 12:59:08PM +0300, Leon Romanovsky wrote:
>> On Tue, Jul 08, 2025 at 10:46:54AM +0200, Johan Hovold wrote:
>> > Make sure to drop the OF node reference taken when creating an auxiliary
>> > device using auxiliary_device_create() when the device is later
>> > released.
>> 
>> I'm probably missing something, but random grep for the
>> device_set_of_node_from_dev() callers shows that none of them are
>> calling to of_node_put() explicitly.
>
> Yeah, the platform bus code takes care of dropping the reference for
> platform devices.

There is an of_node_get() that needs balancing indeed, Thanks

Reviewed-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

>
> Johan

-- 
Jerome