Re: [PATCH v5 06/10] media: i2c: ov9282: add led_mode v4l2 control

[Sakari Ailus]

Hi Richard,

Thanks for the update.

On Tue, Jun 17, 2025 at 09:31:40AM +0200, Richard Leitner wrote:
> Add V4L2_CID_FLASH_LED_MODE support using the "strobe output enable"
> feature of the sensor. This implements following modes:
> 
>  - V4L2_FLASH_LED_MODE_NONE, which disables the strobe output
>  - V4L2_FLASH_LED_MODE_FLASH, which enables the strobe output

I really think you should use a different control for this. The sensor can
strobe the flash but it won't control its mode.

How about calling it V4L2_FLASH_STROBE_ENABLE?

-- 
Kind regards,

Sakari Ailus