Re: [PATCH] soc: hisilicon: kunpeng_hccs: Fix incorrect log information

[lihuisong (C)]

在 2025/7/11 18:38, Jonathan Cameron 写道:
> On Fri, 11 Jul 2025 14:37:06 +0800
> Huisong Li <lihuisong@xxxxxxxxxx> wrote:
>
> > The hccs_get_all_spec_port_idle_sta() will tell user which port
> > is busy when firmware doesn't allow to decrease HCCS lane number.
> > However, the current log prints the index of die and port instead
> > of the hardware ID user perceived.
> >
> > Signed-off-by: Huisong Li <lihuisong@xxxxxxxxxx>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
>
> Maybe adding an example of a wrong print and how it is fixed to this
> patch description would make the problem even more obvious?
Yes.
The problem and modification are very simple, and this description is 
also enough.
> Not worth respin for that though!
ok, thanks for your review.
> > ---
> >   drivers/soc/hisilicon/kunpeng_hccs.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/hisilicon/kunpeng_hccs.c b/drivers/soc/hisilicon/kunpeng_hccs.c
> > index 7fc353732d55..65ff45fdcac7 100644
> > --- a/drivers/soc/hisilicon/kunpeng_hccs.c
> > +++ b/drivers/soc/hisilicon/kunpeng_hccs.c
> > @@ -1295,11 +1295,11 @@ static int hccs_get_all_spec_port_idle_sta(struct hccs_dev *hdev, u8 port_type,
> >   				if (ret) {
> >   					dev_err(hdev->dev,
> >   						"hccs%u on chip%u/die%u get idle status failed, ret = %d.\n",
> > -						k, i, j, ret);
> > +						port->port_id, chip->chip_id, die->die_id, ret);
> >   					return ret;
> >   				} else if (idle == 0) {
> >   					dev_info(hdev->dev, "hccs%u on chip%u/die%u is busy.\n",
> > -						k, i, j);
> > +						 port->port_id, chip->chip_id, die->die_id);
> >   					return 0;
> >   				}
> >   			}