Re: [PATCH] iio: proximity: sx9500: use stack allocated buffer for scan data

From: Jonathan Cameron
Date: Sun Jul 13 2025 - 09:58:28 EST


On Sun, 13 Jul 2025 14:55:33 +0100
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Fri, 11 Jul 2025 19:42:25 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > On Fri, Jul 11, 2025 at 10:47:57AM -0500, David Lechner wrote:
> > > Use IIO_DECLARE_BUFFER_WITH_TS() to declare a stack allocated buffer
> > > in sx9500_trigger_handler(). Since the scan buffer isn't used outside
> > > of this function, it doesn't need to be in struct sx9500_data.
> > >
> > > By always allocating enough space for the maximum number of channels,
> > > we can avoid having to reallocate the buffer each time buffered reads
> > > are enabled.
> >
> > Ag ood one!
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
>
> Applied.
>

Actually on second thoughts - why not a more descriptive structure?
There are only a max of 4 channels and so the timestamp is always
in the same location.

Dropped for now.

Jonathan