RE: [PATCH v3 1/4] net: renesas: rswitch: rename rswitch.c to rswitch_main.c

[Yoshihiro Shimoda]

Hello Michael-san,

> From: Michael Dege, Sent: Thursday, July 10, 2025 9:31 PM
> 
> Adding new functionality to the driver. Therefore splitting into multiple
> c files to keep them manageable. New functionality will be added to
> separate files.
> 
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

I think that these Reviewed-by: tags should be placed after your Signed-off-by
because you got these tags after you submitted.

> Signed-off-by: Michael Dege <michael.dege@xxxxxxxxxxx>

Anyway, this patch looks good to me.

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/net/ethernet/renesas/Makefile                      | 1 +
>  drivers/net/ethernet/renesas/{rswitch.c => rswitch_main.c} | 0
>  2 files changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/renesas/Makefile b/drivers/net/ethernet/renesas/Makefile
> index f65fc76f8b4df8dd9f24af836b6dc0772965366f..6222298bb5582b7091cf8de76acb83ac7dd39c11 100644
> --- a/drivers/net/ethernet/renesas/Makefile
> +++ b/drivers/net/ethernet/renesas/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_SH_ETH) += sh_eth.o
>  ravb-objs := ravb_main.o ravb_ptp.o
>  obj-$(CONFIG_RAVB) += ravb.o
> 
> +rswitch-objs := rswitch_main.o
>  obj-$(CONFIG_RENESAS_ETHER_SWITCH) += rswitch.o
> 
>  obj-$(CONFIG_RENESAS_GEN4_PTP) += rcar_gen4_ptp.o
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch_main.c
> similarity index 100%
> rename from drivers/net/ethernet/renesas/rswitch.c
> rename to drivers/net/ethernet/renesas/rswitch_main.c
> 
> --
> 2.49.0