Re: [PATCH net v3 2/3] net: phy: allow drivers to disable polling via get_next_update_time()

[Oleksij Rempel]

On Sat, Jul 12, 2025 at 02:18:48PM +0100, Simon Horman wrote:
> > +			if (phydev->drv->update_stats) {
> > +				WARN_ONCE("phy: %s: driver requested IRQ mode but needs polling for stats\n",
> > +					  phydev_name(phydev));
> 
> The first argument to WARN_ONCE() should be a condition, not a format string.
> 
> Flagged by GCC and Clang builds with KCFLAGS=-Wformat-security

Thank you! I added it to my build test setup.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |