Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer

[Krzysztof Kozlowski]

On 14/07/2025 15:43, Wei Fang wrote:
>> On 14/07/2025 12:28, Wei Fang wrote:
>>>>>
>>>>> Currently, the enetc driver uses the PCIe device number and function
>> number
>>>>> of the Timer to obtain the Timer device, so there is no related binding in
>> DTS.
>>>>
>>>> So you just tightly coupled these devices. Looks poor design for me, but
>>>> your choice. Anyway, then use that channel as information to pass the
>>>> pin/timer/channel number. You do not get a new property for that.
>>>>
>>>
>>> I do not understand, the property is to indicate which pin the board is
>>> used to out PPS signal, as I said earlier, these pins are multiplexed with
>>
>> Sure, I get it and my argument for phandle cells stays. If you decide
>> not to use it, you do not get a new property.
> 
> I do not know how to add the phandle cells, a phandle value is a way to
> reference another node in the DTS. But for the NETC Timer, what node
> does it need to reference? To be honest, I have no idea.


I don't think you tried hard enough... I asked to read other bindings.
If you did that, you would notice timestamper property and argument.


Best regards,
Krzysztof