Re: [PATCH v3 1/2] mm/huge_memory: move unrelated code out of __split_unmapped_folio()

From: David Hildenbrand
Date: Mon Jul 14 2025 - 14:55:13 EST


On 14.07.25 19:18, Zi Yan wrote:
remap(), folio_ref_unfreeze(), lru_add_split_folio() are not relevant to
splitting unmapped folio operations. Move them out to the caller so that
__split_unmapped_folio() only handles unmapped folio splits. This makes
__split_unmapped_folio() reusable.

Convert VM_BUG_ON(mapping) to use VM_WARN_ON_ONCE_FOLIO().

Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>
Acked-by: Balbir Singh <balbirs@xxxxxxxxxx>
---

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb