RE: [PATCH v2 1/8] dt-bindings: iio: imu: Add inv_icm45600

[Remi Buisson]

>
>
>From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> 
>Sent: Monday, July 14, 2025 7:39 AM
>To: Remi Buisson <Remi.Buisson@xxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; David Lechner <dlechner@xxxxxxxxxxxx>; Nuno Sá <nuno.sa@xxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>
>Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v2 1/8] dt-bindings: iio: imu: Add inv_icm45600
>
>On 10/07/2025 10:57, Remi Buisson via B4 Relay wrote:
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    minItems: 1
>> +    maxItems: 2
>> +
>> +  interrupt-names:
>> +    minItems: 1
>> +    maxItems: 2
>> +    items:
>> +      enum:
>> +        - INT1
>> +        - INT2
>
>This can be simpler
>
>minItems: 1
>items:
>  - enum: [ int1, int2 ]
>  - const: int 2
>
>and use lowercase anyway.
Hello Krzysztof, thanks for your review.
Ok, got it!
>
>> +    description: Choose chip interrupt pin to be used as interrupt input.
>> +
>> +  drive-open-drain:
>> +    type: boolean
>> +
>> +  vdd-supply:
>> +    description: Regulator that provides power to the sensor
>> +
>> +  vddio-supply:
>> +    description: Regulator that provides power to the bus
>> +
>> +  mount-matrix:
>> +    description: an optional 3x3 mounting rotation matrix
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - interrupt-names
>
>Missing supplies
Are supplies always required ?
They are not present for invensense,icm426000 nor for st,lsm6dsx.
>
>> +
>> +allOf:
>> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/gpio/gpio.h>
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        icm45605@68 {
>
>It does not look like you tested the DTS against bindings. Please run
>`make dtbs_check W=1` (see
>Documentation/devicetree/bindings/writing-schema.rst or
>https://urldefense.com/v3/__https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/__;!!FtrhtPsWDhZ6tw!Dse6zIqgRmQ8nxzdmpC7Uu96WBVwNWbql_4WnfPwjuISbauv7GGsDO2zSDTq4TEzSeb0s6fcbmFR$[linaro[.]org]
>for instructions).
>Maybe you need to update your dtschema and yamllint. Don't rely on
>distro packages for dtschema and be sure you are using the latest
>released dtschema.
>
>(see how other bindings or DTS call this type of device)
>
I successfully ran "make dt_binding_check" with up-to-date testing branch.
I'll try dtbs_check as suggested, thanks!

>> +            compatible = "invensense,icm45605";
>> +            reg = <0x68>;
>> +            interrupt-parent = <&gpio2>;
>> +            interrupt-names = "INT1";
>> +            interrupts = <7 IRQ_TYPE_EDGE_RISING>;
>> +            vdd-supply = <&vdd>;
>> +            vddio-supply = <&vddio>;
>> +            mount-matrix = "0", "-1", "0",
>> +                           "1", "0", "0",
>> +                           "0", "0", "1";
>> +        };
>Best regards,
>Krzysztof
>