Re: [PATCH v13] vhost: Reintroduces support of kthread API and adds mode selection

From: Markus Elfring
Date: Tue Jul 15 2025 - 14:45:10 EST


> This patch reintroduces kthread mode for vhost workers and provides
> configuration to select between kthread and task worker.


Is there a need to reconsider the relevance once more for the presented
cover letter?



> +++ b/drivers/vhost/vhost.c

> +static int vhost_attach_task_to_cgroups(struct vhost_worker *worker)
> +{

> + vhost_worker_queue(worker, &attach.work);
> +
> + mutex_lock(&worker->mutex);

> + worker->attachment_cnt = saved_cnt;
> +
> + mutex_unlock(&worker->mutex);


Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&worker->mutex);”?
https://elixir.bootlin.com/linux/v6.16-rc6/source/include/linux/mutex.h#L225

Regards,
Markus