Re: [PATCH v2 1/3] dt-bindings: sound: add bindings for pm4125 audio codec
From: Alexey Klimov
Date: Thu Jul 24 2025 - 11:17:15 EST
On Fri Jul 18, 2025 at 2:43 PM BST, Lee Jones wrote:
> On Fri, 11 Jul 2025, Alexey Klimov wrote:
>
>> The audio codec IC is found on Qualcomm PM4125/PM2250 PMIC.
>> It has TX and RX soundwire slave devices hence two files are added.
>>
>> While at this, also add pattern for respecive node in mfd
>> qcom,spmi-pmic schema so the devicetree for this audio block of
>> PMIC can be validated properly.
>>
>> Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx>
>> ---
>> .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 +-
>> .../bindings/sound/qcom,pm4125-codec.yaml | 134 +++++++++++++++++++++
>> .../devicetree/bindings/sound/qcom,pm4125-sdw.yaml | 79 ++++++++++++
>
> Do you have to submit these all in a single patch?
qcom,pm4125-codec.yaml and qcom,pm4125-sdw.yaml describe one device (sub-device)
and change for qcom,spmi-pmic.yaml is needed to avoid failing dtbs check.
In theory I can split soundwire slave bindings from IC bindings itself and
I may get questions why bindgings for one device is submitted in two steps.
If you really want me to do this, then please let me know.
Otherwise I don't see huge benefits of splitting it since they
are logically and physically connected.
BR,
Alexey