Re: [PATCH v2 5/8] media: platform: amd: isp4 subdev and firmware loading handling added

[Sultan Alsawaf]

On Wed, Jun 18, 2025 at 05:19:56PM +0800, Bin Du wrote:
> +static int isp4_parse_fwnode_init_async_nf(struct isp4_device *isp_dev)
> +{
> +	struct isp4_subdev *isp_sdev = &isp_dev->isp_sdev;
> +	struct device *dev = &isp_dev->pdev->dev;
> +	struct v4l2_fwnode_endpoint bus_cfg = {
> +		.bus_type = V4L2_MBUS_CSI2_DPHY
> +	};
> +	struct fwnode_handle *remote_ep = NULL;
> +	struct fwnode_handle *local_ep = NULL;

[snip]

> +err_fwnode:
> +	if (remote_ep)
> +		fwnode_handle_put(remote_ep);
> +	if (local_ep)
> +		fwnode_handle_put(remote_ep);

Copy/paste error: the second fwnode_handle_put() should put `local_ep`.

> +
> +	return ret;
> +}

Sultan