Re: [PATCH] rtc: twl: Check return value of platform_get_irq()

[Markus Elfring]

…
> > +++ b/drivers/rtc/rtc-twl.c
> > @@ -224,8 +224,11 @@ static int twl_rtc_alarm_irq_enable(struct device *dev, unsigned enabled)
> >  {
> >  	struct platform_device *pdev = to_platform_device(dev);
> >  	struct twl_rtc *twl_rtc = dev_get_drvdata(dev);
> > -	int irq = platform_get_irq(pdev, 0);
> > -	int ret;
> > +	int irq, ret;
> > +
> > +	irq = platform_get_irq(pdev, 0);
> > +	if (irq < 0)
> > +		return irq;
> 
> It won't ever fail because we know it already succeeded earlier.

An execution failure would be strange at this place after a successful function call
within twl_rtc_probe(), wouldn't it?
https://elixir.bootlin.com/linux/v6.16-rc7/source/drivers/rtc/rtc-twl.c#L504-L519

Regards,
Markus