Re: [PATCH v6 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S22

[Violet]

On 7/17/25 20:19, Konrad Dybcio wrote:

> On 7/17/25 1:17 AM, Violet wrote:
> > Add new device support for the Samsung Galaxy S22 (SM-S901E) phone
> >
> > What works:
> > - SimpleFB
> > - USB
> >
> > Signed-off-by: Violet <violet@atl.tools>
> > ---
> [...]
>
> > +&tlmm {
> > +	gpio-reserved-ranges = <36 4>, <50 1>;
> Do you know what these are connected to?
>
> We tend to document it, see e.g. x1-crd.dtsi
>
> > +};
> > +
> > +&usb_1 {
> > +	/* USB 2.0 only */
> > +	qcom,select-utmi-as-pipe-clk;
> Is that a hardware limitation? I thought these phones had the necessary
> pins connected (for DeX)..
>
> > +	status = "okay";
> A newline before 'status' is good practice, file-wide
>
> Konrad

Thank you, I'll fix these issues on the next patchset. Indeed it is not a

hardware limitation, I just kept it USB 2.0 for now to avoid any

potential issues with 3.0.