Re: [PATCH] LoongArch: vDSO: remove -nostdlib complier flag

[Yanteng Si]

在 7/25/25 9:26 PM, Wentao Guan 写道:
> It is clear to remove the -nostdlib for ld, it is similar to commit
> bdbf2038fbf4 ("MIPS: VDSO: remove -nostdlib compiler flag").
>
> Signed-off-by: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
Since MIPS has removed this, we should remove it too. In fact, other architectures also use $(LD).

      fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO")
      691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to link VDSO")
      2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO")
      2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")

If Huacai is willing to apply this patch, I suggest supplementing the commit message.


Reviewed-by: Yanteng Si <siyanteng@xxxxxxxxxxxxxxxxx>

Thanks,
Yanteng
> ---
>   arch/loongarch/vdso/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> index ccd2c5e135c6..d8316f993482 100644
> --- a/arch/loongarch/vdso/Makefile
> +++ b/arch/loongarch/vdso/Makefile
> @@ -36,7 +36,7 @@ endif
>   
>   # VDSO linker flags.
>   ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> -	$(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared --build-id -T
> +	$(filter -E%,$(KBUILD_CFLAGS)) -shared --build-id -T
>   
>   #
>   # Shared build commands.