Re: [PATCH V1 1/3] dt-bindings: ufs: qcom: Add reg and reg-names
From: Krzysztof Kozlowski
Date: Wed Jul 30 2025 - 08:44:47 EST
On 30/07/2025 13:33, Krzysztof Kozlowski wrote:
>>> "extending" but you are not extending at all.
>>>
>>> Recent qcom patches love to break ABI and impact users. No.
>>>
>>> Best regards,
>>> Krzysztof
>>
>>
>> Hi Krzysztof,
>>
>> Thanks for your feedback.
>>
>> Regarding your concern about this being an incompatible change — could you please clarify what specific aspect you believe breaks compatibility?
>> From my side, I’ve carefully tested the patch and verified that it does not break any existing DTs. I ran the following command to validate against the schema:
>
>
> I missed that earlier list is not actually used for SM8550 and SM8650.
> The syntax is a bit confusing after looking only at diff, which probably
> means this binding is getting messy.
>
> I think binding should be just split the constraints are easier to follow.
I sent a patch for splitting the bindings.
Best regards,
Krzysztof