Re: [PATCH V3 2/3] mmc: sdhci-pci-gli: GL9763e: Rename the gli_set_gl9763e() for consistency

[Victor Shih]

On Wed, Jul 30, 2025 at 11:54 PM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>
> On 29/07/2025 09:58, Victor Shih wrote:
> > From: Victor Shih <victor.shih@xxxxxxxxxxxxxxxxxxx>
> >
>
> Also needs to explain in the commit message, why it has a stable tag, say:
>
>         In preparation to fix replay timer timeout, rename the gli_set_gl9763e() to
>         gl9763e_hw_setting() for consistency.
>
> With that:
>
> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>

Hi, Adrian

I will update the commit message in the next version and also keep
your acked-by tag.

Thanks, Victor Shih

> > Rename the gli_set_gl9763e() to gl9763e_hw_setting() for consistency.
> >
> > Signed-off-by: Victor Shih <victor.shih@xxxxxxxxxxxxxxxxxxx>
> > Fixes: 1ae1d2d6e555 ("mmc: sdhci-pci-gli: Add Genesys Logic GL9763E support")
> > Cc: stable@xxxxxxxxxxxxxxx
> > ---
> >  drivers/mmc/host/sdhci-pci-gli.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> > index f678c91f8d3e..436f0460222f 100644
> > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > @@ -1753,7 +1753,7 @@ static int gl9763e_add_host(struct sdhci_pci_slot *slot)
> >       return ret;
> >  }
> >
> > -static void gli_set_gl9763e(struct sdhci_pci_slot *slot)
> > +static void gl9763e_hw_setting(struct sdhci_pci_slot *slot)
> >  {
> >       struct pci_dev *pdev = slot->chip->pdev;
> >       u32 value;
> > @@ -1925,7 +1925,7 @@ static int gli_probe_slot_gl9763e(struct sdhci_pci_slot *slot)
> >       gli_pcie_enable_msi(slot);
> >       host->mmc_host_ops.hs400_enhanced_strobe =
> >                                       gl9763e_hs400_enhanced_strobe;
> > -     gli_set_gl9763e(slot);
> > +     gl9763e_hw_setting(slot);
> >       sdhci_enable_v4_mode(host);
> >
> >       return 0;
>